Make sure that the assign text and buttons show in the right spot #40735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The assign to section button isn't looking right to me: on latest staging: on this branch: (I get the same behavior on chrome and safari) |
|
@bethanyaconnor i think i fixed |
|
Not to be that person but the buttons are still a bit mis-aligned, though not nearly as noticeably My opinion is that this isn't a ship-blocker though. |
bethanyaconnor
approved these changes
May 25, 2021
|
@bethanyaconnor you are totally right. I will go back and try to track that down too. Thank you for your thoughtful review |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amanda reported that the assign text and icon on the student view in Safari looked weird. I went in and updated things so everything aligns nicely now on safari and chrome.