Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When clone_with_suffix for level copy the level_concept_difficulty too #40751

Merged
merged 9 commits into from
May 27, 2021
Merged

When clone_with_suffix for level copy the level_concept_difficulty too #40751

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6d2817b
Copy level concept difficulty when you copy the level
dmcavoy May 21, 2021
852b441
Copy LCD when copying level
dmcavoy May 21, 2021
5153eb1
Copy lcd when cloning level with suffix
dmcavoy May 25, 2021
fe1d474
Remove extras space
dmcavoy May 25, 2021
ebd5a52
Merge branch 'staging' into copy-level-with-lcd
dmcavoy May 26, 2021
f2cda47
Delete script to copy since we should no longer need it
dmcavoy May 26, 2021
9b0f92c
Add a test to make sure we clone the level concept difficulty for a c…
dmcavoy May 26, 2021
abb6f4e
Update dashboard/app/models/levels/level.rb
dmcavoy May 26, 2021
cad9269
Revert "Update dashboard/app/models/levels/level.rb"
dmcavoy May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 0 additions & 39 deletions bin/curriculum/copy_level_concept_difficulties_between_years.rb
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions dashboard/app/models/levels/level.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,11 @@ def clone_with_suffix(new_suffix, editor_experiment: nil)
end
end

# Copy the level_concept_difficulty of the parent level to the new level
update_params[:level_concept_difficulty] = level_concept_difficulty.dup

level.update!(update_params)

level
end

Expand Down
17 changes: 17 additions & 0 deletions dashboard/test/models/level_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,6 +940,23 @@ def create_maze
assert_equal contained_level_2_copy, level_2_copy.contained_levels.last
end

test 'clone with suffix copies level concept difficulty' do
level_1 = create :level, name: 'level 1'
level_1.assign_attributes(
'level_concept_difficulty' => {'sequencing' => 3, 'debugging' => 5}
)

refute_nil level_1.level_concept_difficulty
assert_equal 3, level_1.level_concept_difficulty.sequencing
assert_equal 5, level_1.level_concept_difficulty.debugging

level_1_copy = level_1.clone_with_suffix(' copy')

refute_nil level_1_copy.level_concept_difficulty
assert_equal 3, level_1_copy.level_concept_difficulty.sequencing
assert_equal 5, level_1_copy.level_concept_difficulty.debugging
end

test 'clone with suffix sets editor experiment' do
old_level = create :level, name: 'old level'
new_level = old_level.clone_with_suffix(' copy', editor_experiment: 'level-editors')
Expand Down