Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the painter maximum speed to be much higher #40779

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

jmkulwik
Copy link
Contributor

After a discussion with curriculum, we realized the maximum painter speed should be nearly infinite. i.e. it should look like the painting just appeared. This PR increases the maximum speed while maintaining the same minimum speed.
Details in this slack thread

PainterMoveFaster

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@jmkulwik jmkulwik requested a review from a team May 26, 2021 19:14
Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for putting a comment on the math :)

@jmkulwik jmkulwik merged commit ff15ec3 into staging Jun 2, 2021
@jmkulwik jmkulwik deleted the increase-painter-speed branch June 2, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants