Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rtl image spacing #40818

Merged
merged 1 commit into from May 27, 2021
Merged

fix rtl image spacing #40818

merged 1 commit into from May 27, 2021

Conversation

JillianK
Copy link
Contributor

In removing spacing from PaneButtons that don't have icons as part of this change, I removed the spacing between RTL PaneButtons that use the hiddenImage property instead of the iconClass property to set the icon in the button. This adds a check on the hiddenImage property before removing icon padding.

From the eyes test, the show blocks button here is an example of the issue
Screen Shot 2021-05-27 at 12 58 04 PM

Here's the fixed version on show blocks
Screen Shot 2021-05-27 at 12 52 56 PM

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@JillianK JillianK requested a review from breville May 27, 2021 20:00
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JillianK JillianK merged commit 8618a70 into staging May 27, 2021
@JillianK JillianK deleted the jk-hiddenImage branch May 27, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants