Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot for apps #40837

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Dependabot for apps #40837

merged 1 commit into from
Jun 2, 2021

Conversation

maureensturgeon
Copy link
Contributor

@maureensturgeon maureensturgeon commented May 27, 2021

This creates our dependabot.yml which will allow dependabot to start automatically opening PRs. To start, we will only be using dependabot to upgrade our npm packages. There is a pull request limit of 1, so only 1 dependabot PR can be open at a time. We will be ignoring react dependencies for now, since there is a larger effort already happening to upgrade React. Dependabot upgrades dependencies to the latest version, I looked to see if there was a way to update versions incrementally (for versions that are far behind) and didn't find anything so this may be painful initially.

For more information about configuration see https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates.

Open questions

  • Are there other dependencies we should be ignoring besides React?

Follow-ups

  • Put in place a process for who reviews dependabot PRs so we can stay on top of them. (DoTD?)
  • Add documentation that provides guidance on how to review dependency upgrade PRs. Ex: what to look for in patch, minor and major version upgrades. (I'd love help/guidance with this part)

@maureensturgeon maureensturgeon marked this pull request as ready for review May 27, 2021 23:59
@maureensturgeon maureensturgeon requested review from clareconstantine and a team May 27, 2021 23:59
@jamescodeorg
Copy link
Contributor

Looks good to me, but I think you'll probably want to get some advice on this from the broader team?

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for answering my questions in Slack! I don't know much about the dependabot format but the approach makes sense to me. Thanks for leading the way on this!

@maureensturgeon maureensturgeon merged commit 9413dcc into staging Jun 2, 2021
@maureensturgeon maureensturgeon deleted the dependabot-for-apps branch June 2, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants