Restore "preserve level variants when saving script editor" #40872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
changed the title
| @@ -364,11 +364,12 @@ const serializeLesson = (lesson, levelKeyList) => { | |||
| s.push('variants'); | |||
| level.ids.forEach(id => { | |||
| const active = id === level.activeId; | |||
| s.push(` ${serializeLevel(levelKeyList, id, level, active)}`); | |||
| const lines = serializeLevel(levelKeyList, id, level, active); | |||
| s = s.concat(lines.map(line => ` ${line}`)); | |||
| }); | |||
| s.push('endvariants'); | |||
There was a problem hiding this comment.
should this line and line 364 not also be concat?
There was a problem hiding this comment.
I think either would work because s.push and s = s.concat do the same thing when passed a string. serializeLevel is different because it (confusingly) returns an array.
bethanyaconnor
approved these changes
Jun 1, 2021
davidsbailey
deleted the
revert-40868-revert-40807-preserve-variant-script-update
branch
This was referenced Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40868, restoring #40807 . The problem was that I accidentally changed
.concatto.push, because I thought the thing being passed in was a string rather than an array.Testing story
The new unit test is a bit contrived, but will do the job of preventing a similar regression if this code changes again before it is removed.