Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AiLab] Fixed spacing and text overflow issues in model card #40877

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

made-line
Copy link
Contributor

This PR addresses the following:

  • There were no spaces between the feature names in the Summary section of the model card.
  • The text overflowed past a subsection of the model card.

Before:
Screen Shot 2021-06-01 at 1 44 28 PM

After:
Screen Shot 2021-06-01 at 1 47 17 PM

@@ -113,7 +113,8 @@ const styles = {
borderRadius: 5,
borderColor: color.gray,
marginBottom: 10,
padding: 10
padding: 10,
overflowWrap: 'breakWord'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this work? I think it should be "break-word". (You can double-check it's valid by inspecting the element in the browser debugger.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! I conflated this with the spacing change. Now it's showing up in the browser debugger. Thank you!

@made-line made-line merged commit 2af4071 into staging Jun 2, 2021
@made-line made-line deleted the model-card-formatting branch June 2, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants