Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neighborhood: version up maze and add take paint command #40878

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

molly-moen
Copy link
Contributor

This PR gets version 2.4.0 of Maze and adds the take paint command to neighborhood. Take paint takes paint from a paint can and adds it to the painter's supply.

The paint can addition on Maze can be seen here. We were already doing the styling of the units on a maze cell (ex. for collector) on the code-dot-org side, so I added an additional class on the paint can value on the Maze side and added the relevant css here so we can resize the font for Neighborhood.

This PR updates our neighborhood levels (allthethings Javalab 1 and 3) to include paint cans. I resized level 3 from 16x16 to 15x15 (our max size that can include a paint can) and changed the background images a bit, along with adding paint cans.

Java Lab 1 now looks like this:
Screen Shot 2021-06-01 at 1 58 21 PM

Java Lab 3:
Screen Shot 2021-06-01 at 1 58 18 PM

Links

Testing story

Tested locally.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen requested review from maddiedierker and a team June 1, 2021 21:01
Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@molly-moen molly-moen merged commit 07bc799 into staging Jun 1, 2021
@molly-moen molly-moen deleted the neighborhood-paint-can branch June 1, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants