Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mini view links from white to blue #40879

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Jun 1, 2021

The links in the lesson descriptions in the mini view were showing up as white. This fixes them to make them blue.

Before

Screen Shot 2021-06-01 at 5 42 32 PM

After

Screen Shot 2021-06-01 at 5 39 36 PM

@dmcavoy dmcavoy requested a review from a team June 1, 2021 21:43
@davidsbailey
Copy link
Member

@madelynkasula can you offer an opinion on whether it is ok to add styles to application.scss like this?

@dmcavoy
Copy link
Contributor Author

dmcavoy commented Jun 1, 2021

@madelynkasula can you offer an opinion on whether it is ok to add styles to application.scss like this?

I tried adding it in the curriculum/level.scss and it was going overwritten by the application.scss stuff.

@davidsbailey
Copy link
Member

@madelynkasula can you offer an opinion on whether it is ok to add styles to application.scss like this?

I tried adding it in the curriculum/level.scss and it was going overwritten by the application.scss stuff.

If your initial goal was to put this in level.scss, then let's pursue that a bit further. was the rule you added there of greater CSS specificity than any conflicting rules in application.scss?

@dmcavoy
Copy link
Contributor Author

dmcavoy commented Jun 2, 2021

@madelynkasula can you offer an opinion on whether it is ok to add styles to application.scss like this?

I tried adding it in the curriculum/level.scss and it was going overwritten by the application.scss stuff.

If your initial goal was to put this in level.scss, then let's pursue that a bit further. was the rule you added there of greater CSS specificity than any conflicting rules in application.scss?

I think so but I can try again.

@dmcavoy
Copy link
Contributor Author

dmcavoy commented Jun 2, 2021

Screen Shot 2021-06-01 at 8 22 03 PM

@dmcavoy
Copy link
Contributor Author

dmcavoy commented Jun 2, 2021

Ah if I bring the .header-wrapper and .header it seems to work

@dmcavoy dmcavoy merged commit 4773494 into staging Jun 2, 2021
@dmcavoy dmcavoy deleted the white-links-mini-view branch June 2, 2021 12:33
@maddiedierker
Copy link
Contributor

i know i'm late to this, but thank you for refactoring the styles into level.scss! i'd like for us to move away from using application.scss so that: 1) our frontend can eventually control all styles, and 2) application.scss (or its equivalent, hopefully on the frontend) is only used for global styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants