Update control buttons #40977
Merged
Update control buttons #40977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddiedierker
commented
Jun 4, 2021
| @@ -8,15 +8,20 @@ | |||
| padding: 0; | |||
| } | |||
|
|
|||
| .cm-content, .cm-gutter { | |||
| .cm-content, | |||
There was a problem hiding this comment.
note: most of the changes in this file are formatting changes from prettier
jmkulwik
reviewed
Jun 4, 2021
apps/src/javalab/ControlButtons.jsx
Outdated
| }} | ||
| > | ||
| <JavalabButton | ||
| text={isRunning ? 'Stop' : 'Run'} |
There was a problem hiding this comment.
Should these be internationalized? (same question for other strings)
There was a problem hiding this comment.
they weren't in i18n before, so i left them as-is, but i'll add them to the javalab/locale file
jmkulwik
reviewed
Jun 4, 2021
apps/src/javalab/ControlButtons.jsx
Outdated
| all: { | ||
| fontSize: 16, | ||
| width: 140, | ||
| justifyContent: 'center', |
There was a problem hiding this comment.
The justify-center feels pretty odd. Would left make more sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the control buttons to match Figma and moves the 'continue' button to a temporary spot (it and the 'settings' button will be moved/re-styled next week):
Screen.Recording.2021-06-04.at.1.09.18.PM.mov
There's also some clean-up to:
stylesdefinition below component definition<InputPrompt/>into a separate fileisHorizontalprop in<JavalabButton/>to actually make the icon/text horizontally stackedLinks