Bump Javalab Codemirror version #41273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencodeorg
commented
Jun 23, 2021
| @@ -9635,13 +9635,25 @@ lezer-tree@^0.13.0: | |||
| resolved "https://registry.yarnpkg.com/lezer-tree/-/lezer-tree-0.13.0.tgz#199757338a30e4c5ee8d9a767546d7ce8935bfbe" | |||
| integrity sha512-YqGD22WxQmT6np2JEX5Z+zhdBSfPEcQ8B6ct+39oLzSAHecUPUd/maN5PKNtnUZbSzd81mEx1ZqzMDA1eRSRcg== | |||
|
|
|||
| lezer-tree@^0.13.2: | |||
There was a problem hiding this comment.
First time upgrading our apps dependencies -- these look like code-mirror dependencies, but is there any best practice for confirming that I'm not accidentally bumping the version of things that I didn't intend to change?
There was a problem hiding this comment.
the only way I know to do that would be to search in this file to see if other packages depend on lezer-tree.
molly-moen
approved these changes
Jun 23, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on readonly mode for Javalab, I found that there are some relevant features that are only available in a 0.18.x release (namely, preventing copy/paste when your Code Mirror is in readonly mode). This PR bumps all Codemirror packages to 0.18.x. This change broke our Dark/Light mode, so it includes changes to resolve those issues. More info on the changes in 0.18 is here.
Testing story
I tested these changes manually by switching back and forth between light and dark mode and generally playing around with the editor. It appears these packages are only used in Javalab currently, so I only tested there.
Follow-up work
Will follow this up with work on read only mode.