Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax course offering version keys #41284

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Jun 23, 2021

A small PR to prepare for all of our assignable scripts to have a course offering and version. My plan is to create course offerings with the same name as the script, such as 20-hour. As this has a number, it fails the course offering key validation. These scripts also don't have a year associated with them so I'm planning on having the course version key either be their name or "unversioned" (I'm still deciding on this), so I relaxing that validation in this PR as well.

I modeled both of these on the resource key validation, so I don't think it will break any markdown syntax but definitely let me know if there's something I should check for.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor marked this pull request as ready for review June 28, 2021 15:51
@bethanyaconnor bethanyaconnor requested a review from a team June 28, 2021 15:51
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for breaking these changes down like this.

@bethanyaconnor bethanyaconnor merged commit 50caee5 into staging Jun 29, 2021
@bethanyaconnor bethanyaconnor deleted the relax-course-offering-version-keys branch June 29, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants