Fix only_one_running to support git content updates #41285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, `git pull` will replace a file with a new inode at the same path when updating file contents. This isn't compatible with `flock`, so we need to lock against a separate temporary file instead.
sureshc
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes,
git pullwill replace a file with a new inode at the same path when updating file contents. This isn't compatiblewith
flock(which locks against the inode directly and not the filesystem path more generally). As a workaround, this PR updatesonly_one_running?to lock against a separate temporary file (derived from an MD5 hash of the filesystem path) instead.Links
INF-454Testing story
Added
test_replaced_fileas a unit test that fails without this PR and passes with the fix.