Remove runButton step from star wars test #41313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescodeorg
force-pushed
the
jamescodeorg/fix-starwars-test
branch
from
7843a23
to
541588a
Compare
| @@ -15,7 +14,10 @@ Scenario: Starwars Flow | |||
| And I click selector ".project_save" | |||
| And I wait until element ".project_edit" is visible | |||
| Then I should see title "Code Ninja III: Revenge of the Semicolon - Play Lab" | |||
| And I press "runButton" | |||
| # There used to be a 'And I press "runButton"' step here but it causes the test | |||
There was a problem hiding this comment.
Is it necessary to leave this comment?
There was a problem hiding this comment.
i second that question. not sure this comment is useful going forward.
There was a problem hiding this comment.
Ok, I'll just remove it, thanks!
jamescodeorg
force-pushed
the
jamescodeorg/fix-starwars-test
branch
from
541588a
to
3731f3f
Compare
maureensturgeon
approved these changes
Jun 28, 2021
cforkish
approved these changes
Jun 28, 2021
jamescodeorg
force-pushed
the
jamescodeorg/fix-starwars-test
branch
from
3731f3f
to
65e59af
Compare
jamescodeorg
force-pushed
the
jamescodeorg/fix-starwars-test
branch
from
65e59af
to
c7c342a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the
And I press "runButton"step because it causes the test to hang on Chrome for reasons unknown (LP-1958). This step is not important to the scenario and the functionality is separately covered in hour_of_code/starwars.feature so we decided to just remove the step.Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: