Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local map fix #41356

Merged
merged 4 commits into from
Jun 30, 2021
Merged

Local map fix #41356

merged 4 commits into from
Jun 30, 2021

Conversation

annaxuphoto
Copy link
Contributor

@annaxuphoto annaxuphoto commented Jun 28, 2021

The map on https://code.org/learn/local is not calculating its position correctly, and the position: sticky property is not working as expected (these bugs were hard to reproduce locally, because a difference in element height made scrolling on the local environment unnecessary).

This PR adds a bottomSpacing property to the map's sticky call such that the map does not overlap the footer. It also recalculates bottomSpacing when the window is resized, to adjust dynamically to a potentially different footer height.

Links

Jira

Testing story

  • forced the document height to 2000px in order to correctly test scrolling
  • resized the window multiple times in a single page load to ensure that the bottomSpacing updates correctly

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@annaxuphoto annaxuphoto requested a review from a team June 28, 2021 23:05
@annaxuphoto annaxuphoto merged commit 002b087 into staging Jun 30, 2021
@annaxuphoto annaxuphoto deleted the local-map-fix branch June 30, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants