Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable asset retrieval in javalab local mode #41360

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

molly-moen
Copy link
Contributor

Javabuilder is being updated to allow for programs to retrieve assets (images, audio) from the assets system (See this PR. This PR updates the local setup for the Javalab connection to Javabuilder to include the channel id needed to generate the asset urls. The non-local version already has this information.

The update linked above also removes the need for the projects url to be passed. Removed this on the local side here (and therefore this should be merged after the Javabuilder PR), and put a note to remove it on the session token side once Javabuilder has been deployed with the updates. Removing it from the session token now could cause Javabuilder to break if we do things in the wrong order.

Links

Testing story

Tested locally against local Javabuilder with the new updates.

Deployment strategy

This should be merged after the Javabuilder change is merged to avoid local development errors.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen requested a review from a team June 28, 2021 23:46
Copy link
Contributor

@sanchitmalhotra126 sanchitmalhotra126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I know there's some more conversation on the JavaBuilder side on how this should work, but for local testing this seems fine

Copy link
Contributor

@hannahbergam hannahbergam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@molly-moen molly-moen merged commit a710b9f into staging Jun 30, 2021
@molly-moen molly-moen deleted the enable-assets-in-javabuilder branch June 30, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants