Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only postprocess Lesson content if we have translations #41374

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jun 29, 2021

Otherwise, any language that hasn't translated any Lesson content will fail because result[:lessons] is expected to be nil in that case.

I recommend reviewing with whitespace changes disabled: https://github.com/code-dot-org/code-dot-org/pull/41374/files?w=1

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Otherwise, any language that hasn't translated any Lesson content will fail because `result[:lessons]` is expected to be `nil` in that case.
@Hamms Hamms requested review from daynew and a team June 29, 2021 21:49
@Hamms Hamms merged commit 96a5f3e into staging Jun 30, 2021
@Hamms Hamms deleted the only-postprocess-lessons-if-we-have-lessons branch June 30, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants