Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javalab: automatically toggle stop to run on program completion #41474

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

molly-moen
Copy link
Contributor

@molly-moen molly-moen commented Jul 7, 2021

After a Javalab program has completed execution, automatically toggle the 'stop' button back to 'run'. This works as expected for console and neighborhood levels, and for theater we never toggle back to run as we cannot determine the stop time of the gif/audio. This is desired behavior from product/curriculum.

Links

Testing story

Tested locally

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen requested review from a team and bencodeorg July 7, 2021 23:20
@molly-moen molly-moen merged commit b0829f0 into staging Jul 8, 2021
@molly-moen molly-moen deleted the javalab-toggle-run branch July 8, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants