Javalab: code review UI #41478
Merged
Javalab: code review UI #41478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molly-moen
reviewed
Jul 8, 2021
| @@ -1,7 +1,16 @@ | |||
| import React, {Component} from 'react'; | |||
| //import PropTypes from 'prop-types'; | |||
There was a problem hiding this comment.
It's going to be re-added when I start including real comments as props, which is imminently 🤞
| commentContainer: { | ||
| margin: '0 0 25px 0' | ||
| }, | ||
| projectOwnerComment: { |
There was a problem hiding this comment.
I think we want the background to be blue when the comment is from 'you' (so if you are a peer/teacher and are looking at your comment on someone else's project, or if it's your own project and your own comment). Is that right @moneppo?
There was a problem hiding this comment.
Ooh that would make sense!
| const teacherCommentSuffix = ` (${javalabMsg.onlyVisibleToYou()})`; | ||
| return ( | ||
| <span> | ||
| <span style={styles.name}>{name}</span> |
There was a problem hiding this comment.
per the figma I think we want this to be 'you' if it is your comment
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic UI components for Javalab code review feature -- a
Commentcomponent to render a single comment, and aCommentEditorcomponent to create a new comment and submit it.Testing story
Added unit tests for behavior added in this PR (eg, different background colors on comments based on who the comment is from). More tests to come as this gets hooked up to the back end.
Follow-up work
The UI isn't quite perfectly lined up with the Figma mocks, so probably some additional work to get things to look juust right (eg, date text overflows when a comment is from a teacher). I also did not include the menu that will be shown when a user clicks on the ellipsis yet.
I'll also delete the demo comments as I start working on getting this to work with the back end.