Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicating middle-high.js to avoid entry point check failures #41507

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

annaxuphoto
Copy link
Contributor

To unblock staging, we are duplicating middle-high.js in order to circumvent the following entry point check error:

✘ code.org/public/student/middle-high ➜ ./src/sites/code.org/pages/public/student/middle-high.js
  ✘ Entry points should only be used by one template but this one is used by 2!
  this entry point is referenced by the following templates:
    ../pegasus/sites.v3/code.org/public/student/middle-high-alt.haml
                                 public/student/middle-high.haml

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge without waiting for drone, to unblock the staging build.

@annaxuphoto annaxuphoto merged commit f2252d4 into staging Jul 9, 2021
@annaxuphoto annaxuphoto deleted the duplicate-middle-high-js branch July 9, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants