New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearer Student vs. Teacher user type selection on sign-up page (ensuring browser-wide support) #41608
Clearer Student vs. Teacher user type selection on sign-up page (ensuring browser-wide support) #41608
Conversation
031cde1
to
5b34032
Compare
… required field is left blank
Is the mobile view meant to have the content in the top left corner? Can we enlarge the element/remove margins so it takes up the full mobile view? |
@annaxuphoto I think it may be intentional that the content is like that? Every step of the sign up and log in process is like that (I used my phone to confirm that as well). I can definitely look into making this step more enlarged, I think my concern would just be that it might be a weird inconsistency if that's the only step that is enlarged to fill the screen. What do you think? I'm totally fine going either way! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline that we are tracking the mobile formatting issue in a separate backlog item. Otherwise LGTM :)
This PR makes the abilities of a Student vs. a Teacher clearer on the sign-up page. Instead of a drop-down that says "Student" and "Teacher," there are 2 large buttons that describe each one. This way, teachers are more likely to see that they have all the abilities a student has (including seeing from a student's view) and will actually select the "Teacher" user type. These changes are toggled by the experiment clearerSignUpUserType.
Note about similar previous PR: Previous PR of this used implementation that wasn't supported by IE11 so that was reverted and this one fixes it. This PR also now ensures that if the user type is selected but some other required field is not filled in and the user tries to sign up, the choice they made for user type will still persist and be selected so that they do not have to redo that (meaning they would only have to provide input for whichever required field they left blank).
Screenshots
Here is the original look (experiment off):
Here is the updated look (experiment on) which can be found by turning on the experiment with this link (and this experiment can be turned off with this link) once the branch is merged into staging:
Here is the mobile view:
Here is what it looks like when a user tries to sign up without selecting either option (the expected behavior is what is shown where the red text tells the user they need to deliberately pick a user type):
Links
Spec can be found here.
Testing story
Manually tested by switching between Student and Teacher account types and made an account with both successfully. Also checked that the user cannot create an account without explicitly clicking either 'Student' or 'Teacher.' Finally, using an ad-hoc environment I checked that this functionality persists across browsers.
Follow-up work
If this is all good to go in staging, I will create an Optimizely A/B experiment to test its efficacy.