-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the commit modal to save to backpack and support new flow #41668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molly-moen
reviewed
Jul 26, 2021
maureensturgeon
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I definitely defer to the CSA team though
molly-moen
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the backpack/commit modal. It utilizes the built in button settings for disabled/abled colors. The final modal differs slightly from the Figma spec, so here are the logic rules:
Because the default buttons site-wide use gray as a default color instead of a light gold, we switched to match the settings for the green buttons (therefore removing the use of orange/gold at all).
The Cancel button closes the dialog exactly the way the corner "X" does.
The different states of the button colors and text are shown below.
Files compile, no commit notes yet or files checked for save:
Files compile, no commit notes, files checked for save:
Files compile, commit notes, no files checked for save:
Files compile, commit notes, files checked for save:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: