Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the commit modal to save to backpack and support new flow #41668

Merged
merged 16 commits into from
Jul 27, 2021

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Jul 21, 2021

This PR updates the backpack/commit modal. It utilizes the built in button settings for disabled/abled colors. The final modal differs slightly from the Figma spec, so here are the logic rules:

  1. The Commit button is "Commit" if there are no backpack files checked, "Commit & Save" otherwise
  2. The Commit button is greyed out until there are commit notes
  3. The compilation status only displays if there are backpack files checked

Because the default buttons site-wide use gray as a default color instead of a light gold, we switched to match the settings for the green buttons (therefore removing the use of orange/gold at all).

The Cancel button closes the dialog exactly the way the corner "X" does.

The different states of the button colors and text are shown below.

Files compile, no commit notes yet or files checked for save:
image

Files compile, no commit notes, files checked for save:
image

Files compile, commit notes, no files checked for save:
image

Files compile, commit notes, files checked for save:
image

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam marked this pull request as ready for review July 26, 2021 19:39
@hannahbergam hannahbergam requested a review from a team as a code owner July 26, 2021 19:39
@hannahbergam hannahbergam marked this pull request as draft July 26, 2021 20:00
@hannahbergam hannahbergam marked this pull request as ready for review July 26, 2021 20:23
apps/src/javalab/CommitDialog.jsx Outdated Show resolved Hide resolved
apps/src/javalab/CommitDialog.jsx Outdated Show resolved Hide resolved
apps/src/javalab/CommitDialog.jsx Outdated Show resolved Hide resolved
apps/src/javalab/CommitDialog.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@maureensturgeon maureensturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I definitely defer to the CSA team though

Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple nits

apps/src/javalab/CommitDialog.jsx Outdated Show resolved Hide resolved
apps/src/javalab/Javalab.js Outdated Show resolved Hide resolved
@hannahbergam hannahbergam merged commit 6b3f918 into staging Jul 27, 2021
@hannahbergam hannahbergam deleted the hbergam/backpack-ui branch July 27, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants