Javalab: show appropriate options in comment options menu #41715
Conversation
bencodeorg
changed the base branch from
staging
to
ben/javalab-peer-review-read-only
…de-dot-org/code-dot-org into ben/javalab-explicit-peer-review-mode
| @@ -45,7 +46,7 @@ export default class Comment extends Component { | |||
| }; | |||
|
|
|||
| renderFormattedTimestamp = timestampString => | |||
| moment.utc(timestampString).format('M/D/YYYY [at] h:mm A'); | |||
| moment(timestampString).format('M/D/YYYY [at] h:mm A'); | |||
There was a problem hiding this comment.
Unrelated fix to show timestamps in local time instead of UTC.
| @@ -136,6 +136,7 @@ Javalab.prototype.init = function(config) { | |||
| channelId: config.channel, | |||
| isProjectLevel: !!config.level.isProjectLevel, | |||
| isEditingStartSources: this.isStartMode, | |||
| isCodeReviewing: !!config.isCodeReviewing, | |||
There was a problem hiding this comment.
Curious how this gets set - will config.isCodeReviewing be updated every time a user switches to another student's project via the review dropdown?
There was a problem hiding this comment.
It gets passed in from the controller here and is set as a page constant (I believe such that it cannot be changed once the page is loaded):
As far as I know, we'll be fully reloading the page for one student to view another student's work, so we'd be setting isCodeReviewing to true on page load after a student selects another student from the dropdown.
| @@ -8,7 +10,9 @@ import * as codeReviewDataApi from './codeReview/codeReviewDataApi'; | |||
|
|
|||
| const FLASH_ERROR_TIME_MS = 5000; | |||
|
|
|||
| export default class ReviewTab extends Component { | |||
| class ReviewTab extends Component { | |||
| static propTypes = {viewAsCodeReviewer: PropTypes.bool.isRequired}; | |||
There was a problem hiding this comment.
nit: add // populated by redux?
The "comment options" menu is an ellipsis that appear on each comment to show the option to delete a comment (only for teachers) and to resolve/re-open a comment (only for project owner). This PR:
isPeerReviewingthat is passed from the back end when one student is viewing another student's code.Student reviewing another student's work
Student looking at their own project
Teacher looking at student work
Testing story
Tested manually with two students in the same section and a teacher. Also added unit tests.