Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show parent levels in admin panel #41733

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Show parent levels in admin panel #41733

merged 4 commits into from
Jul 27, 2021

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jul 26, 2021

Alongside the list of scripts the given level is in, also show a list of other levels that the given level is in.

Resolves PLAT-227

description screenshot
contained level image
sublevel of a single bubble choice image
sublevel of multiple bubble choices image
not a child of any other level image

Open to suggestions if there's anything else that would be useful to link to here!

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Alongside the list of scripts the given level is in, also show a list of other levels that the given level is in.
@Hamms Hamms requested a review from a team July 26, 2021 22:42
%p{style: 'width: 400px;'}
%small
%strong NOTE:
This list currently only includes contained levels, project template levels, and BubbleChoice sublevels. Other methods of embedding levels inside other levels are not yet supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this works for LevelGroup sublevels too:
Screen Shot 2021-07-26 at 4 30 22 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, right!

image

%p{style: 'width: 400px;'}
%small
%strong NOTE:
This list currently only includes contained levels, project template levels, and sublevels (both BubbleChoice and LevelGroup). Other methods of embedding levels inside other levels are not yet supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I think this covers all types of embedding levels inside other levels now, so I would suggest something like This list includes contained levels, project template levels, and sublevels (both BubbleChoice and LevelGroup). I'm not sure I could explain to a curriculum writer what other types of level relationships there are which are missing here, so if there are other relationships you have in mind it could be helpful to list those here.

@davidsbailey
Copy link
Member

Curriculum Writers are going to love this!

@Hamms Hamms merged commit f6a6fee into staging Jul 27, 2021
@Hamms Hamms deleted the show-parent-levels-in-editor branch July 27, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants