Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore "Use serialized_maze and start_direction from template level in Javalab levels" #41743

Merged

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Jul 26, 2021

Reverts #41742, restoring #41689. The original PR broke neighborhood levels without a start_direction and without a template level.

@bethanyaconnor bethanyaconnor changed the title Revert "Revert "Use serialized_maze and start_direction from template level in Javalab levels"" Restore "Use serialized_maze and start_direction from template level in Javalab levels" Jul 26, 2021
@bethanyaconnor bethanyaconnor marked this pull request as ready for review July 27, 2021 20:26
@bethanyaconnor bethanyaconnor requested a review from a team July 27, 2021 20:26
Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the breaking issue fixed in a different pr or is it fixed here?

@bethanyaconnor
Copy link
Contributor Author

It's fixed here in commit d082b26

@bethanyaconnor bethanyaconnor merged commit 2505894 into staging Jul 28, 2021
@bethanyaconnor bethanyaconnor deleted the revert-41742-revert-41689-javalab-template-fields branch July 28, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants