Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n sync Down & Out 07/27 #41756

Merged
merged 87 commits into from
Jul 28, 2021
Merged

I18n sync Down & Out 07/27 #41756

merged 87 commits into from
Jul 28, 2021

Conversation

deploy-code-org
Copy link
Contributor

I18n Sync Down & Out

This PR contains all changes to translations made since the last sync (usually a week).

To Review:

Look through the changes in each of the commits and verify that all changes are expected. Note that it is not necessary to review every single "dashboard i18n update" commit. These commits are batched by language to make it easier to review just a couple commits in this category.

Things to Note:

  • We expect translation changes to come in on a regular basis; new strings will be translated, existing translations will be updated, and source string removals will result in translations for those strings also being removed.

  • We expect translations to arrive in large batches, so don't worry if you see a large group of changes in a specific language.

  • We do not usually expect to see a large number of formatting changes, or batches of changes that apply to strings in every single language. If you see this, it usually means either that a code change went in or that something broke.

Known Issues:

  • If the CI unit tests fail at the grunt messages:all step, they will typically fail with a message like:

    [2019-10-04 02:38:57] Running "messages:all" (messages) task
    [2019-10-04 02:39:00] Warning: Error processing localization file i18n/common/zh_tw.json: SyntaxError: Expected [0-9a-zA-Z$_] but "\u8A0A" found. Use --force to continue. 
    

    This usually means that a translator has translated one of the MessageFormat variables. In this case, you should find and fix the offending translation in crowdin, and then manually update the associated strings in i18n/locales and apps/i18n.

    See ab3e5d1 and 0fca376 for an example.

To Deploy:

Once one or two people have reviewed and approved this change and the tests are passing, ship it!

It's not necessary to wait for everyone on the team to review.

@deploy-code-org deploy-code-org requested a review from a team as a code owner July 27, 2021 18:00
@deploy-code-org
Copy link
Contributor Author

This comment is created by running: bin/i18n/analyze_pr.rb -p 41756 -c

Top 5/1178 files sorted by the number of changes:

  • bin/i18n/crowdin/codeorg_etags.json, 28998 changes (14499 additions, 14499 deletions).
  • dashboard/config/locales/activity_sections.lt-LT.json, 5045 changes (4516 additions, 529 deletions).
  • dashboard/config/locales/activity_sections.ku-IQ.json, 5033 changes (4654 additions, 379 deletions).
  • dashboard/config/locales/activity_sections.te-IN.json, 5031 changes (4656 additions, 375 deletions).
  • dashboard/config/locales/activity_sections.co-CO.json, 5021 changes (4659 additions, 362 deletions).

Top 5/86 commits sorted by the number of changes:

  • Commit: etags updates
    • 29666 changes (14833 additions, 14833 deletions).
    • 3 files changed.
    • File with the most changes: bin/i18n/crowdin/codeorg_etags.json, 28998 changes (14499 additions, 14499 deletions).
  • Commit: dashboard i18n updates - Kurdish
    • 10582 changes (9990 additions, 592 deletions).
    • 10 files changed.
    • File with the most changes: dashboard/config/locales/activity_sections.ku-IQ.json, 5033 changes (4654 additions, 379 deletions).
  • Commit: dashboard i18n updates - Urdu (Pakistan)
    • 10559 changes (9934 additions, 625 deletions).
    • 7 files changed.
    • File with the most changes: dashboard/config/locales/activity_sections.ur-PK.json, 4982 changes (4567 additions, 415 deletions).
  • Commit: dashboard i18n updates - Tamil
    • 10397 changes (9884 additions, 513 deletions).
    • 9 files changed.
    • File with the most changes: dashboard/config/locales/activity_sections.ta-IN.json, 5010 changes (4635 additions, 375 deletions).
  • Commit: dashboard i18n updates - Telugu
    • 10389 changes (9944 additions, 445 deletions).
    • 7 files changed.
    • File with the most changes: dashboard/config/locales/activity_sections.te-IN.json, 5031 changes (4656 additions, 375 deletions).

@hacodeorg hacodeorg merged commit db79029 into staging Jul 28, 2021
@hacodeorg hacodeorg deleted the i18n-sync-down-out-07-27-2021 branch July 28, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants