Fnd 1613 add curriculum unplugged to i18n sync #41758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daynew
force-pushed
the
fnd-1613-add-curriculum-unplugged-to-i18n-sync
branch
2 times, most recently
from
73cb845
to
6836bec
Compare
In order to make this page translatable, we first needed to remove all the embedded ruby code because it is a security risk to allow translators to write arbitrary Ruby code which is executed on our servers.
daynew
force-pushed
the
fnd-1613-add-curriculum-unplugged-to-i18n-sync
branch
from
6836bec
to
8fbff28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make https://code.org/curriculum/unplugged translatable. That URL is currently rendered by
pegasus/sites.v3/code.org/public/curriculum/unplugged.md.erb. This is a problem because it is an Embedded RuBy (.erb) file. Making this file available for translation would mean that translators could make our servers execute malicious ruby scripts. This fix is to instead make it a Markdown(.md) file which has all the plain text translators need. The existing ruby code we need to execute for the video thumbnails are instead hidden away in different files (partials) which will not be made available to translators..partialis added tounplugged.mdto enable these sub-templates. Ultimately we end up withpegasus/sites.v3/code.org/public/curriculum/unplugged.md.partialwhich should be safe for translation.Links
Testing story
i18n/locales/source/markdown/public/curriculum/unplugged.mdwas createdPR Checklist: