Add code review UI messages #41781
Merged
Add code review UI messages #41781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molly-moen
approved these changes
Jul 28, 2021
bencodeorg
approved these changes
Jul 28, 2021
| <div style={styles.commentsSection}> | ||
| <div style={styles.messageText}>{javalabMsg.feedbackBeginning()}</div> | ||
| {this.renderComments(comments, !isReadyForReview)} | ||
| {this.renderCommentEditor(forceRecreateEditorKey)} |
jmkulwik
reviewed
Jul 28, 2021
| marginBottom: '25px', | ||
| textAlign: 'center', | ||
| fontStyle: 'italic', | ||
| color: '#818181' |
There was a problem hiding this comment.
Where possible, prefer one of our existing colors, listed here: https://github.com/code-dot-org/code-dot-org/blob/staging/shared/css/color.scss
There was a problem hiding this comment.
They can be used like this:
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah nice, thanks! These are helpful - I didn't find the exact same grey in this file, but I can use something similar if it's not noticeably different or add this to colors.scss
jmkulwik
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UI messages to the code review window and some associated view/style reorganization. Messages are shown based on whether the student has comments in the project and if peer review is enabled or not. Note - this only includes messages for a student viewing their own project. For students viewing another student's project, there is a different header message that is still TODO (pending peer review dropdown).
Peer.Review.Messages.UI.7.28.mov
Links
https://codedotorg.atlassian.net/browse/CSA-557
Testing story
Tested locally.
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: