Javalab: add route to get reviewable projects for level #41785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molly-moen
approved these changes
Jul 28, 2021
|
@bencodeorg I think the query is fine, I seem to recall it was hard/impossible to determine section id from a level. Indexes are a good idea! |
…m:code-dot-org/code-dot-org into ben/javalab-reviewable-project-list-route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add route to return list of reviewable projects, such that we can include a dropdown of available projects to review in the review tab in Javalab.
Testing story
Added unit tests.
Follow-up work
Note the rather complicated query required to get the list of students whose projects should be considered for review. I think if we included
section_idas a field in ReviewableProject, this could be a lot cleaner. That said, I'm not sure we have a super clean way of associating student progress with a specific section ID, so that part might be tricky.Also we need to follow up to index this table appropriately to allow us to efficiently query by user/level/script ID -- work item here