[Blockly] Targeted performance fixes #41804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epeach
approved these changes
Jul 29, 2021
ajpal
commented
Jul 29, 2021
apps/src/p5lab/spritelab/blocks.js
Outdated
| @@ -609,7 +609,6 @@ export default { | |||
| block.setHSV(136, 0.84, 0.8); | |||
| block.parameterNames_ = [i18n.thisSprite()]; | |||
| block.parameterTypes_ = [Blockly.BlockValueType.SPRITE]; | |||
| block.setUserVisible(false); | |||
There was a problem hiding this comment.
I'm not 100% sure why, but this is causing behaviors to break entirely - I thought it would be a purely UI change but it doesn't appear to be. I will dig into this more, but I think we should go ahead with this PR without this change since it'll still fix the majority of the lag
There was a problem hiding this comment.
fyi @epeach, but lmk if you have any concerns about this!
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in code-dot-org/blockly#280 and code-dot-org/blockly#281
Also sets
behavior_definitionblocks in spritelab to not user visible so we don't have to render them (they're already hidden, we just weren't setting the block property).Slack threads:
https://codedotorg.slack.com/archives/C0T0PNTM3/p1627571617462700
https://codedotorg.slack.com/archives/C01V27QS9AT/p1627581282013800