Upgrade react-tooltip #41843
Merged
Upgrade react-tooltip #41843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Drone failure here is: learning_platform/level_types/level_group_multi_page_dots again which means maybe you've isolated the issue? |
|
yes! still confused as to why this upgrade causes the failure, but it's consistent, so i think we've found the root cause. this upgrade isn't essential to getting react upgraded, so i think we can pause on this or have LP revisit separately |
maddiedierker
force-pushed
the
upgrade-react-tooltip
branch
from
7a7d605
to
cb9dc49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #41582 as it doesn't depend on the React upgrade. Manually verified some tooltips in teacher dashboard after the upgrade.
This upgrade was causing an LP UI test to fail (level_group_multi_page_dots.feature) when inspecting progress in the dropdown. We manually verified the behavior is working as expected and decided to comment those steps out for LP to investigate later (Slack thread / LP Jira follow-up task).