-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create table to store code commit comments #41964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came to project_versions
as a name for this as well before I noticed Suresh suggested the same thing in the tech spec :). I think probably worth renaming especially with the not obvious "metadatum" class name you get as the singular of "metadata"
Sorry one other comment -- do you want |
Oh right probably not -- we want storage_app_id/version_id to be unique and we want a non-unique index on storage_app_id. I'll fix -- good catch! |
Two votes for this is enough for me. I'll update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good to know. Thanks.
This comes from the tech spec. I used the table name from the spec but there was a bit of discussion about it so let me know if there's a different name folks would prefer!
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: