Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create table to store code commit comments #41964

Merged
merged 4 commits into from
Aug 11, 2021

Conversation

bethanyaconnor
Copy link
Contributor

This comes from the tech spec. I used the table name from the spec but there was a bit of discussion about it so let me know if there's a different name folks would prefer!

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor requested a review from a team as a code owner August 10, 2021 19:37
@bethanyaconnor bethanyaconnor requested a review from a team August 10, 2021 19:38
Copy link
Contributor

@bencodeorg bencodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came to project_versions as a name for this as well before I noticed Suresh suggested the same thing in the tech spec :). I think probably worth renaming especially with the not obvious "metadatum" class name you get as the singular of "metadata"

@bencodeorg
Copy link
Contributor

Sorry one other comment -- do you want storage_app_id to be unique?

@bethanyaconnor
Copy link
Contributor Author

do you want storage_app_id to be unique?

Oh right probably not -- we want storage_app_id/version_id to be unique and we want a non-unique index on storage_app_id. I'll fix -- good catch!

@bethanyaconnor
Copy link
Contributor Author

I came to project_versions as a name for this as well before I noticed Suresh suggested the same thing in the tech spec

Two votes for this is enough for me. I'll update

Copy link
Contributor

@bakerfranke bakerfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to know. Thanks.

@bethanyaconnor bethanyaconnor merged commit f44a9ef into staging Aug 11, 2021
@bethanyaconnor bethanyaconnor deleted the create-code-commit-table branch August 11, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants