New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teacher opt-in to share email information with regional partners #42034
Merged
TurnerRiley
merged 14 commits into
staging
from
share-teacher-email-regional-partner-opt
Aug 31, 2021
Merged
Teacher opt-in to share email information with regional partners #42034
TurnerRiley
merged 14 commits into
staging
from
share-teacher-email-regional-partner-opt
Aug 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h regional partner
…greement to opting in. Otherwise, store nothing in that parameter
…tly choose to opt in or out
…r is ever required
…ing in or out of sharing email with regional partners
…d to opt in or out to avoid confusion due to similarity with User.properties value with simialr name
smusoke
reviewed
Aug 24, 2021
smusoke
reviewed
Aug 31, 2021
smusoke
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give teachers the ability to opt-in to sharing their emails with Code.org regional partners. Code.org’s regional partners offer local professional development workshops and community events for teachers. If they share their contact information with the partner in their state, the regional partner can notify the opted-in teachers of these opportunities and resources.
This choice (in the form of a radio button) will appear in the sign-up page for teachers in the United States and will be an optional choice (essentially defaulting to 'No'). This PR does not do the actual sharing of emails, it simply stores whether a given teacher has opted in to this program in their
User.properties
under the variable nameshare_teacher_email_regional_partner_opt_in
.The value of
share_teacher_email_regional_partner_opt_in
inUser.properties
based on the scenario (where N/A signifies that in this scenario the given choice would not be available to the user):share_teacher_email_regional_partner_opt_in
DateTime.now
to mark when they opted inOld vs. new appearance
Original view teachers in the U.S. saw
New view teachers in the U.S. will now see (every other scenario (e.g. a teacher in another country) will look the exact same as the original)
Links
Here is the spec.
Testing story
/dashboard/test/controllers/registrations_controller_test.rb
. The names of each scenario's respective unit test is listed in the 2nd-to-last column of the table below.User.properties
where each row represents a user such that the last row ofUser.properties
is the set of properties from the most-recently-created user.share_teacher_email_regional_partner_opt_in
inUser.properties
registrations_controller_test.rb
DateTime.now
to mark when they opted inFuture work
Start the Optimizely A/B experiment to ensure the presence of this new opt-in choice doesn't impede the rate of new users successfully signing up. It tracks this through number of successful sign-ups in both versions of the A/B experiment. This feature is toggled using the experiment flag "OPT_IN_EMAIL_REG_PARTNER". Once this PR is pushed, the experiment flag can be toggled using these links (which Optimizely will do for users automatically): ON / OFF.
If this will be run at the same time as the "Teacher vs. Student" experiment, then they will be run as mutually exclusive experiments.
Privacy
Does not store any extra personal information. At most, it will store a time stamp of when (if they did) select yes to sharing their email with a Code.org regional partner. As for the sharing of the email itself, the spec answers that with the following: "This does not necessitate a change to our privacy policy. Once we share the teacher’s email address with a regional partner, we no longer have a responsibility for how that teacher can unsubscribe from emails from the regional partner (they manage it at that point)."