-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to React 16.14 #42169
Upgrade to React 16.14 #42169
Conversation
ed86f80
to
d31fcf5
Compare
// TODO: Add warnings back once redux/react-redux have been upgraded. | ||
// https://codedotorg.atlassian.net/browse/XTEAM-376 | ||
// throwOnConsoleWarningsEverywhere(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the through documentation in the PR description and code TODOs! This will make follow up sooo much easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! I'm so excited & happy to see this coming together!
One tiny NIT: In the description, you have this line
Is there a second thing that should be upgraded? The wording seems to imply react-select and something else needs to be upgraded. |
no, this means we need to upgrade react-select (currently at ^1.2.1) to version 4, but that it should happen in 2 steps (upgrade to v2 first then to v4) because of the large API changes. the "respectively" part is referring to the jira tasks -- XTEAM-328 is for the v2 upgrade, and XTEAM-364 is for v4. i'll update that bullet to clarify! |
Upgrades React from 15.4 to 16.14, along with some supplementary changes and test fixes. Tracked as XTEAM-362.
Depends on #42168. Reapplies the changes in #42157, which were reverted in #42165. I merged the original PR in order to confirm which UI/eyes tests would fail on the test environment. Those failures are logged here. (Note: there were actually less eyes test failures when we deployed this change because I ended up splitting the redux/react-redux into a separate PR.)
We had each cabal bug bash to smoke test their parts of the product. Results here.
Description of each commit in this change
Follow-up work