Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip IE for Oceans UI tests #42176

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Skip IE for Oceans UI tests #42176

merged 2 commits into from
Aug 25, 2021

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Aug 24, 2021

We don't support Oceans in IE so disabling that browser for the hoc_ml UI test, which was recently flaky.

Copy link
Contributor

@sureshc sureshc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -1,6 +1,6 @@
Feature: Oceans ML HoC

@no_circle @no_mobile @no_safari
@no_circle @no_mobile @no_safari @no_ie
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking as this should be a quick change, but couldn't all these settings be set at once at the top of this file?

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this! Added a question but feel free to ignore :)

@Erin007 Erin007 merged commit fcae203 into staging Aug 25, 2021
@Erin007 Erin007 deleted the oceans-ml-no-ie branch August 25, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants