[Spritelab] Fixes for validation code #42177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1151,7 +1151,7 @@ P5Lab.prototype.initInterpreter = function(attachDebugger = true) { | |||
| this.JSInterpreter.parse({ | |||
| code, | |||
| projectLibraries: this.level.projectLibraries, | |||
| blocks: this.isSpritelab ? [] : dropletConfig.blocks, | |||
| blocks: dropletConfig.blocks, | |||
There was a problem hiding this comment.
[not blocking this PR] why did this break validation code?
There was a problem hiding this comment.
Because validation code often uses console.log and console.log was only getting populated into the interpreter state from Gamelab's droplet config. The change here makes it so that Spritelab will have access to gamelab's whole droplet config again, but that's just the fastest way to resolve this issue. Longer term, we need to figure out the right way to do this without the implicit dependence on Gamelab's droplet config.
maddiedierker
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports came in that
console.logwas not working in validation code anymore, it turns out this was a regression from #42141. Along the way, I also found that thegetBackgroundfunction needed an additional guard for the case where the background is undefined.Slack threads:
https://codedotorg.slack.com/archives/C1B3PNDL7/p1629820166079300