Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui test unversioned course and script redirects #42229

Merged
merged 1 commit into from Aug 31, 2021

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Aug 27, 2021

attempts to fill in a testing blind spot for the HB errors linked in #42221.

the production regression was tied to script/course caching being enabled. drone does not have script caching enabled, but the test machine does:

def self.should_cache?
return false if Rails.application.config.levelbuilder_mode
return false unless Rails.application.config.cache_classes
return false if ENV['UNIT_TEST'] || ENV['CI']

Testing story

I ran this cross-browser and with caching enabled here: #42230

@davidsbailey davidsbailey merged commit 0aac91d into staging Aug 31, 2021
@davidsbailey davidsbailey deleted the unversioned-course-redirects branch August 31, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants