Implement delete_progress API for resetting progress #42235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| test "delete_progress deletes channel tokens" do | ||
| # TODO: Write this test after the work to add script_ids to channel tokens is completed. |
There was a problem hiding this comment.
This could be written now since there is a script_id column on channel tokens.
There was a problem hiding this comment.
I wanted to use the same query methods that are used in the primary codepaths if possible and those haven't been updated to look at script_id yet, right?
| assert driver_user_level.driver? | ||
| assert_equal 1, PairedUserLevel.pairs(driver_user_level).count | ||
|
|
||
| # delete the driver's progress |
There was a problem hiding this comment.
Should be # delete the navigator's progress
There was a problem hiding this comment.
Good catch, thanks!
maureensturgeon
approved these changes
Aug 31, 2021
Base automatically changed from
jamescodeorg/confirm-delete-progress-form
to
staging
August 31, 2021 17:32
jamescodeorg
force-pushed
the
jamescodeorg/delete-progress-api
branch
from
84a2d6a
to
016eab7
Compare
jamescodeorg
commented
Aug 31, 2021
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the the delete_progress API that will be used by admins to reset progress. See the tech spec for details on the design. As part of this work, soft-deletes are now enabled on the UserScript, UserLevel, and ChannelToken models.
The tests try to use the same methods to query the data that our primary codepaths use where possible to make the tests as realistic as possible.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: