[PoemBot][HOC] Validation Code #42243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpal
commented
Aug 29, 2021
| @@ -36,7 +36,8 @@ | |||
| "hide_pause_button": "false", | |||
| "instructions_icon": "poet", | |||
| "callout_json": "[\r\n {\r\n \"localization_key\": \"poetry_background\",\r\n \"callout_text\": \"Find code blocks here. \",\r\n \"element_id\": \"[id=':1.label']\",\r\n \"on\": \"\",\r\n \"qtip_config\": {\r\n \"codeStudio\": {\r\n \"canReappear\": false,\r\n \"dropletPaletteCategory\": \"\"\r\n },\r\n \"style\": {\r\n \"classes\": \"\"\r\n },\r\n \"position\": {\r\n \"my\": \"left center\",\r\n \"at\": \"right center\",\r\n \"adjust\": {\r\n \"x\": 0,\r\n \"y\": 0\r\n }\r\n }\r\n }\r\n }\r\n]", | |||
| "preload_asset_list": null | |||
| "preload_asset_list": null, | |||
| "validation_code": "var validationInfo = getValidationInfo();\r\nif (validationInfo.backgroundEffect) {\r\n setSuccessFrame();\r\n}\r\ndrawProgressBar();\r\nif (World.frameCount == validationInfo.endTime) {\r\n if (validationInfo.successFrame) {\r\n levelFailure(0, 'genericSuccess');\r\n } else {\r\n levelFailure(3, 'poemBotMakeBackground');\r\n }\r\n}" | |||
ajpal
commented
Aug 29, 2021
| @@ -36,7 +36,8 @@ | |||
| "instructions_icon": "poet", | |||
| "callout_json": "[]", | |||
| "parent_level_id": 29611, | |||
| "preload_asset_list": null | |||
| "preload_asset_list": null, | |||
| "validation_code": "var validationInfo = getValidationInfo();\r\nif (validationInfo.foregroundEffect) {\r\n setSuccessFrame();\r\n}\r\ndrawProgressBar();\r\nif (World.frameCount == validationInfo.endTime) {\r\n if (validationInfo.successFrame) {\r\n levelFailure(0, 'genericSuccess');\r\n } else {\r\n levelFailure(3, 'poemBotMakeForeground');\r\n }\r\n}" | |||
ajpal
commented
Aug 29, 2021
| @@ -40,6 +40,7 @@ | |||
| "encrypted_examples": [ | |||
|
|
|||
| ], | |||
| "validation_code": "var validationInfo = getValidationInfo();\r\nvar spriteIds = getSpriteIdsInUse();\r\n\r\nif (spriteIds.length > 0) {\r\n setSuccessFrame();\r\n}\r\ndrawProgressBar();\r\nif (World.frameCount == validationInfo.endTime) {\r\n if (validationInfo.successFrame) {\r\n levelFailure(0, 'genericSuccess');\r\n } else {\r\n levelFailure(3, 'noSprites');\r\n }\r\n}", | |||
ajpal
commented
Aug 29, 2021
| @@ -39,7 +39,8 @@ | |||
| "preload_asset_list": null, | |||
| "encrypted_examples": [ | |||
|
|
|||
| ] | |||
| ], | |||
| "validation_code": "var validationInfo = getValidationInfo();\r\nvar spriteIds = getSpriteIdsInUse();\r\n\r\nfor (var i = 0; i < spriteIds.length; i++) {\r\n if (getProp({id: spriteIds[i]}, \"scale\") !== 100) {\r\n setSuccessFrame();\r\n }\r\n}\r\n\r\ndrawProgressBar();\r\nif (World.frameCount == validationInfo.endTime) {\r\n if (validationInfo.successFrame) {\r\n levelFailure(0, 'genericSuccess');\r\n } else if (spriteIds.length == 0) {\r\n levelFailure(3, 'poemBotRemovedSprite');\r\n } else {\r\n levelFailure(3, 'poemBotSetSize');\r\n }\r\n}" | |||
epeach
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First few levels of validation code. Technically the level validation code could be written directly on Levelbuilder, but I did it on localhost so that I could add translation strings and library hooks at the same time.
I added screenshots of the validation code for each level since the string diff is hard to review.
With editing levels on localhost, there's potential for merge conflicts with the DTL, but if they come up, they should be easy to resolve since Amy is not editing the
validation_codefield on these levels.