Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PoemBot][HOC] Make foreground effects one-time bursts #42259

Merged
merged 8 commits into from
Aug 31, 2021
Merged

[PoemBot][HOC] Make foreground effects one-time bursts #42259

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a658861
allow multiple foreground effects
ajpal Aug 30, 2021
95525a7
Merge branch 'staging' into aug30-foreground-effects
ajpal Aug 30, 2021
1faffe5
update for twinkling
ajpal Aug 30, 2021
594e220
remove old effects
ajpal Aug 30, 2021
0f3684b
make effects one-time bursts
ajpal Aug 30, 2021
7184077
update block text
ajpal Aug 30, 2021
0209143
Merge branch 'staging' into aug30-foreground-effects
ajpal Aug 31, 2021
8f50648
name constants
ajpal Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/src/p5lab/spritelab/libraries/PoemBotLibrary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default class PoemBotLibrary extends CoreLibrary {
effects: []
};
this.backgroundEffect = () => this.p5.background('white');
this.foregroundEffect = () => {};
this.foregroundEffects = [];
this.lineEvents = {};
this.p5.textAlign(this.p5.CENTER);
this.p5.angleMode(this.p5.DEGREES);
Expand Down Expand Up @@ -59,7 +59,7 @@ export default class PoemBotLibrary extends CoreLibrary {

// Don't show foreground effect in preview
if (this.p5.frameCount > 1) {
this.foregroundEffect();
this.foregroundEffects.forEach(effect => effect.func());
}
},

Expand Down