All feedbacks makeover #42260
Merged
All feedbacks makeover #42260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maureensturgeon
force-pushed
the
maureen/LP-1989-all-feedbacks-makeover
branch
from
db2b09e
to
571d152
Compare
jamescodeorg
reviewed
Sep 8, 2021
| : feedbacks.slice(0, 1); | ||
|
|
||
| const hasMultipleFeedbacks = feedbacks.length > 1; | ||
| const marginBottom = hasMultipleFeedbacks ? 8 : 24; |
There was a problem hiding this comment.
For levels that have just one feedback we do not display the "Show older comments" button, so the design has a little bit of extra spacing to make up for the space that we usually get with the button.
jamescodeorg
approved these changes
Sep 9, 2021
| const feedbackSeenByStudent = | ||
| seen_on_feedback_page_at || student_first_visited_at; | ||
|
|
||
| const commentExists = comment.length > 2; |
There was a problem hiding this comment.
Do you know why this is >2? (I see that it is logic carried over from the previous implementation.)
There was a problem hiding this comment.
I'm not sure. Must have been an issue at some point that there were accidental or empty string comments?
dashboard/test/controllers/teacher_feedbacks_controller_test.rb
Outdated
Show resolved
Hide resolved
dashboard/test/controllers/teacher_feedbacks_controller_test.rb
Outdated
Show resolved
Hide resolved
maureensturgeon
commented
Sep 10, 2021
maureensturgeon
force-pushed
the
maureen/LP-1989-all-feedbacks-makeover
branch
from
6eb26d0
to
e1f9c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the all feedbacks page, groups feedback by level, displays only the latest feedback for each level by default. The user can see the full history of feedback given on the level by clicking "Show older comments"
Links
Testing story
Tested locally and added unit tests
PR Checklist: