Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hello world instructors #42358

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Hello world instructors #42358

merged 3 commits into from
Sep 7, 2021

Conversation

mikeharv
Copy link
Contributor

@mikeharv mikeharv commented Sep 7, 2021 •
edited

Add three new images to be used as "instructor" images in Sprite Lab levels: bear.png, emoji.png, and retro.png

Links

Testing story

PR Checklist:

  • [n/a ] Tests provide adequate coverage
  • [ n/a] Privacy and Security impacts have been assessed
  • [n/a ] Code is well-commented
  • [X ] New features are translatable or updates will not break translations
  • [ n/a] Relevant documentation has been added or updated
  • [X ] User impact is well-understood and desirable
  • [ X] Pull Request is labeled appropriately
  • [n/a ] Follow-up work items (including potential tech debt) are tracked and linked

@mikeharv mikeharv requested a review from epeach September 7, 2021 19:58
@mikeharv mikeharv requested a review from a team as a code owner September 7, 2021 19:58
epeach
epeach suggested changes Sep 7, 2021
View reviewed changes
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR - woo hoo! 🎉 I left one comment about a file with unneeded changes. Additionally, it would be great to have more context in the PR description. Here is an example PR when Anjali last added an instructor asset: #42115. Not a whole lot is needed, but just something that makes it easy to take a look at the description and figure out what the purpose of the PR is (adding new instructor assets).

dashboard/db/schema_cache.yml Outdated
@@ -7130,7 +7130,7 @@ columns:
comment:
lessons_opportunity_standards:
- &1825 !ruby/object:ActiveRecord::ConnectionAdapters::MySQL::Column
name: lesson_id
name: id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes in this file are not relevant to your change, so let's remove any changes to this file from this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed as irrelevant. Removed!

epeach
epeach approved these changes Sep 7, 2021
View reviewed changes
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks for making those changes - looks good!

@mikeharv
Copy link
Contributor Author

mikeharv commented Sep 7, 2021

Removed file with unneeded changes. Should just add 3 images for instructor avatars: bear.png, emoji.png, retro.png

bear
emoji
retro

@epeach epeach merged commit 5fd7259 into staging Sep 7, 2021
@epeach epeach deleted the hello-world-instructors branch September 7, 2021 23:37
@mikeharv
Copy link
Contributor Author

@epeach Do you know why these images aren't showing up here? https://github.com/code-dot-org/code-dot-org/tree/levelbuilder/apps/static/spritelab
I'm still not able to add them to a level. I think I'm not clear on the various directories.

@mikeharv mikeharv mentioned this pull request Sep 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epeach epeach epeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikeharv @epeach