Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Upgrade redux & react-redux"" #42360

Merged
merged 4 commits into from
Oct 19, 2021

Conversation

maddiedierker
Copy link
Contributor

@maddiedierker maddiedierker commented Sep 7, 2021

Reverts #42307 to re-apply the redux/react-redux upgrade. The issue users were reporting (details in the linked PR) where some CSF levels weren't loading should be fixed with #42825.

I had internal users try to repro the issue in this bug bash doc. Before the fix linked above, only Chromebook users at certain display resolutions could reproduce the issue. After the fix, I can confirm that a Chromebook that consistently reproduced the issue (only at machine display resolution 1301x731) no longer reproduces this issue.

Links

@maddiedierker maddiedierker force-pushed the revert-42307-revert-42184-upgrade-react-redux branch from b8f7ce4 to 9b048c5 Compare October 12, 2021 23:55
@maddiedierker maddiedierker added the react-16.14-upgrade Upgrading React to 16.14 label Oct 13, 2021
@maddiedierker maddiedierker merged commit a0df8c4 into staging Oct 19, 2021
@maddiedierker maddiedierker deleted the revert-42307-revert-42184-upgrade-react-redux branch October 19, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react-16.14-upgrade Upgrading React to 16.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants