Upgrade Eyes a bit #42371
Upgrade Eyes a bit #42371
Conversation
Upgrade the Eyes gem from 3.17.19 to 3.18.4. Followup to #37650. The debug spew issue has apparently been resolved with this gem version.
There was a problem hiding this comment.
were you able to (or do you know of a way to) run our Eyes test suite before this gets to the test machine? i don't think it's necessarily a blocker for this PR, but would be nice if we could verify changes like this before merging them.
one thing i tried recently that didn't work -- i checked out my feature branch on the test machine and started a DTT on that. all other tests were fine, but the Eyes tests were comparing against really old baselines for some reason. so i'm also interested in better ways to do this for reasons outside of this change 😄
There was a problem hiding this comment.
[from our discussion offline] there doesn't seem to be a good way to make sure this change doesn't break any eyes tests before merging it and allowing it to run in a DTT.
i think the best path forward is to resume the work to allow for eyes tests to be run/approved against staging, so i've taken an action item to talk to @aaronwaggener about that. i'm not sure how much work is left to get it over the finish line, so that will affect how/when we can get that work scheduled. @sureshc is #23122 where we left off with that work?
|
This PR successfully made it through a DTT. |
Upgrade the Eyes gem from 3.17.19 to 3.18.4.
Followup to #37650. The debug spew issue has apparently been resolved with this gem version.