Render valid React for Blockly XML in <SafeMarkdown/> #42415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates our
<SafeMarkdown/>
component to render Blockly XML in a way that is valid React. We do this by wrapping each Blockly element in a custom component and using thecomponents
option in rehype-react.Since Blockly elements aren't valid React (e.g.,
<xml>
isn't a valid React component), we were previously seeing warnings any time Blockly blocks were rendered by our instructions panel:This would also cause unit tests to fail for the same reason (we fail unit tests when console.warn is called), so we no longer have to skip or allow warnings in InstructionsCSFTest.js.
Links
<InstructionsCSF/>
logs warnings for instructions with embedded Blockly blocksTesting story
Updates unit tests.