Disable Varnish #42441
Merged
Disable Varnish #42441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caching behaviors can be handled entirely by CloudFront+Nginx, so Varnish can be disabled. Toggle Varnish with `node['cdo-varnish']['enabled']`.
wjordan
force-pushed
the
disable-varnish
branch
from
5f97664
to
9862ee9
Compare
wjordan
commented
Sep 10, 2021
Comment on lines
+174
to
+195
| *HTTP_CACHE.keys.map do |app_name| | ||
| proxy = (app == :hourofcode) ? :pegasus : app | ||
| { | ||
| Id: app_name == proxy ? 'cdo' : app_name, | ||
| CustomOriginConfig: { | ||
| OriginProtocolPolicy: 'match-viewer', | ||
| OriginSSLProtocols: %w(TLSv1.2 TLSv1.1) | ||
| }, | ||
| DomainName: origin, | ||
| OriginPath: '', | ||
| OriginShield: { | ||
| Enabled: true, | ||
| OriginShieldRegion: {Ref: 'AWS::Region'} | ||
| }, | ||
| OriginCustomHeaders: app_name == proxy ? [] : [ | ||
| { | ||
| HeaderName: 'X-Cdo-Backend', | ||
| HeaderValue: app_name | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| end, |
There was a problem hiding this comment.
This is creating an extra 'Origin' in addition to 'cdo', which the distribution can use as a proxy target (so the pegasus/hourofcode distributions will have an extra dashboard origin, and dashboard will have an extra pegasus origin). The only difference in the second origin is that it sets a custom HTTP request header X-Cdo-Backend to pegasus/dashboard, which nginx then uses as an override when selecting the proper backend app.
This implements the 'proxy' http-cache-config behavior outside of Varnish.
This was referenced Sep 22, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements caching/routing behaviors entirely in CloudFront+Nginx so Varnish can be disabled and removed from the HTTP stack.
Toggle Varnish on/off with
node['cdo-varnish']['enabled'](currently default totrue).