Add Javascript clientState helper. Introduce Mocha+Chai JS test framework for dashboard. #4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbogle
changed the title
| */ | ||
| dashboard.clientState.EXPIRY_DAYS = 365; | ||
|
|
||
| dashboard.clientState.reset = function() { |
There was a problem hiding this comment.
Is there more to the client state than progress and lines? (videos seen, etc). Do we plan on resetting those? If not, then specify what's getting reset here.
There was a problem hiding this comment.
I added the module comment I had previously forgotten and made a note there about future things we'll add.
|
Comments are minor / more questions. Overall, LGTM. |
|
Responded to Mehal's comments, thanks! Added additional tests for malformed cookies. |
…into client_progress_writes
philbogle
added a commit
that referenced
this pull request
Oct 1, 2015
Add Javascript clientState helper. Introduce Mocha+Chai JS test framework for dashboard.
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Javascript accessor functions for progress and lines client state. Update header.js.erb to use these helpers.
Konacha (Mocha + Chai) Test framework
Adds the Konacha test frameworks. In order include unit tests for the functions, the CL integrates the Konacha test framework (mocha + chai + Rails asset pipeline).
In brief, to run all tests interactively in your browser browser of choice:
bundle exec rake konacha:serve
then hit "http://localhost:3500" in the browser
To run dashboard JS unit tests on the command line:
bundle exec rake konacha:run
(
konacha:runrequires that you install phantomjs E.g.brew install phantomjson OSX)