Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let lessons be cloned between years as long as the units both use code studio lesson plans #42560

Merged
merged 3 commits into from
Sep 22, 2021

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Sep 18, 2021

We were preventing cloning of lessons between units if the units were not in the same version year. We have decided that we are not worried about this case as long as we prevent cloning lessons that use legacy lesson plans to scripts that use the new lesson plans on code studio. This change will allow new code studio lessons to be cloned to a unit that is also using new code studio lessons.

Links

Jira: https://codedotorg.atlassian.net/browse/PLAT-1289

Testing story

  • Unit tests

@dmcavoy dmcavoy requested a review from a team September 22, 2021 14:02
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests!

@dmcavoy dmcavoy merged commit d34505e into staging Sep 22, 2021
@dmcavoy dmcavoy deleted the clone-between-years branch September 22, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants