hoc: hide event sign-up during actual-hoc #42581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the 2020 Hour of Code, there was an issue with the event sign-up form when the map on https://hourofcode.com/ was replaced by a static image, which we do each year. It's possible that we can fix this (with some work in #38135 but additional work expected). But last year, we opted to simply hide the form with a temporary hack in #38138 (which was undone in #38343). For now, this just puts that change back in place more formally, so that the event sign-up for is hidden when hoc_mode is "actual_hoc".
breville
requested review from
clareconstantine,
aaronwaggener,
ericfershtman,
a team,
KylieModen and
bethanyaconnor
and removed request for
a team
bethanyaconnor
approved these changes
Sep 21, 2021
aaronwaggener
approved these changes
Sep 21, 2021
KylieModen
approved these changes
Sep 21, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the 2020 Hour of Code, there was an issue with the event sign-up form when the map on https://hourofcode.com/ was replaced by a static image, which we do each year.
It's possible that we can fix this (with some work in #38135 but additional work expected). But last year, we opted to simply hide the form with a temporary hack in #38138 (which was undone in #38343).
For now, this just puts that change back in place more formally, so that the event sign-up for is hidden when
hoc_modeis"actual_hoc".