Add retries to Resource PDF Generation #42600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For background, we've had an intermittent issue with the Curriculum PDF generation process in which when it comes time to collate all our individual PDFs together in the rollup, GhostScript complains that it can't find all the files that we're telling it to roll up, and the PDF generation fails. I've been able to track down the failure to specifically the title pages that we generate in the Resource rollup to differentiate the lessons within a script. Unfortunately, I have been unable to get any kind of reliable repro, much less to figure out *why* this is happening in the first place. Because I know where the problem is but not why it is, and because it happens so rarely as to make further investigation difficult, I'm resorting to a blind retry. It's not a good solution, but it's the best I got at this point.
… thorough filesystem checking in it
| # Adding some logging here to help diagnose. | ||
| unless $?.success? | ||
| ChatClient.log( | ||
| "PDF generation exited with status code #{$?.exitstatus.inspect}", |
There was a problem hiding this comment.
Did you get any helpful error information here? If so, can you summarize what it was before removing it?
There was a problem hiding this comment.
I did and I didn't. This clause never triggered at any point, so in once sense I got no information, and in another sense I learned that even when we end up failing to generate a file (as indicated by the other clause triggering), the process still reports a success. So I'm removing the clause, but it is worth keeping in mind that whatever's going on here, it's subtle.
There was a problem hiding this comment.
That's what I figured, but wanted to double check. Thanks!
bethanyaconnor
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For background, we've had an intermittent issue with the Curriculum PDF generation process in which when it comes time to collate all our individual PDFs together in the rollup, GhostScript complains that it can't find all the files that we're telling it to roll up, and the PDF generation fails.
I've been able to track down the failure to specifically the title pages that we generate in the Resource rollup to differentiate the lessons within a script. Unfortunately, I have been unable to get any kind of reliable repro, much less to figure out why this is happening in the first place.
Because I know where the problem is but not why it is, and because it happens so rarely as to make further investigation difficult, I'm resorting to a retry. It's not a good solution, but it's the best I got at this point.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: